Idan Shaby has posted comments on this change. Change subject: core: Configurable Default for Wipe After Delete per Storage Domain ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35909/3/packaging/dbscripts/upgrade/03_06_0590_add_wipe_after_delete_to_storage_domain_static.sql File packaging/dbscripts/upgrade/03_06_0590_add_wipe_after_delete_to_storage_domain_static.sql: Line 5: Line 6: begin Line 7: v_table = 'storage_domain_static'; Line 8: v_column = 'wipe_after_delete'; Line 9: if (not exists (SELECT 1 > This check is already done inside fn_db_add_column , the function skips the That's true, but than how will I know if I should call the update query or not? I guess that a possible RFE can be to edit fn_db_add_column to return true if the column was added and false if it already existed. Line 10: FROM information_schema.columns Line 11: WHERE table_name = v_table AND Line 12: column_name = v_column)) then Line 13: -- The wipe_after_delete column does not exist. -- To view, visit http://gerrit.ovirt.org/35909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0d5a1c9158be1284ffe05d1bf1397c9113f6c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
