Arik Hadas has uploaded a new change for review. Change subject: core: fix interfaces initialization for VM object ......................................................................
core: fix interfaces initialization for VM object In the constructor of VM object we always set the interfaces to empty list. It is redundant as we get VmStatic object which is initialized with empty list. The problem with the redundant setting is that even if passing VmStatic instance initialized with interfaces, we were override it. Thus, this setting is removed. Change-Id: I4537f48ecfd7f3a42e96e345c24f085105361e02 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/36107/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java index da3995b..a7cb76b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java @@ -89,7 +89,6 @@ this.setDynamicData(vmDynamic); this.setStatisticsData(vmStatistics); this.setImages(new ArrayList<DiskImage>()); - this.setInterfaces(new ArrayList<VmNetworkInterface>()); this.setvNumaNodeList(new ArrayList<VmNumaNode>()); this.setDiskMap(new HashMap<Guid, Disk>()); this.setCdPath(""); -- To view, visit http://gerrit.ovirt.org/36107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4537f48ecfd7f3a42e96e345c24f085105361e02 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
