David Caro has posted comments on this change. Change subject: Adding ovirt node and ovirt node iso projects ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/36058/9/jobs/confs/shell-scripts/build-local-ovirt-node.sh File jobs/confs/shell-scripts/build-local-ovirt-node.sh: Line 4: Line 5: DISTRO="{distro}" Line 6: Line 7: Line 8: # the die on error function > I dont think bash understand {{ after function declaration Bash does not, but those scripts are actually templates that jenkins-job-builder extrapolates. The templating is just formatting a python string (str.format) so the curly brackets must be duplicated to avoid variable expansion. Line 9: function die {{ Line 10: echo "$1" Line 11: exit 1 Line 12: }} -- To view, visit http://gerrit.ovirt.org/36058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If543fe28f200e8254d4d96fa6789db3ced44f2b1 Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
