Martin Mucha has uploaded a new change for review. Change subject: core: Tests for NetworkAttachmentsValidator ......................................................................
core: Tests for NetworkAttachmentsValidator Change-Id: I534a0a200f9a5b7d9faadba766699112b9c6a5b8 Signed-off-by: Martin Mucha <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/36147/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java index 78c6ae5..db24794 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java @@ -80,6 +80,11 @@ : network.isVmNetwork() ? NetworkType.VM : NetworkType.NON_VM; } + /*TODO MM: attachments can form multiple nicname-network mappings; so, nicname can have multiple networks associated, + so nicName can contain duplicate NetworkTypes. Bag.size() does not remove duplicates, so first part of if is probably wrong. + How about replacing List with Set in respective Map? + + */ /** * Make sure that if the given interface has a VM network on it then there is nothing else on the interface, or if * the given interface is a VLAN network, than there is no VM network on the interface.<br> -- To view, visit http://gerrit.ovirt.org/36147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I534a0a200f9a5b7d9faadba766699112b9c6a5b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
