Shubhendu Tripathi has posted comments on this change. Change subject: gluster: DAO for volume snapshot config maintenance ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/35303/8/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotConfigDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotConfigDao.java: Line 9: Line 10: public interface GlusterVolumeSnapshotConfigDao extends DAO, SearchDAO<GlusterVolumeSnapshotConfigParam> { Line 11: public void save(GlusterVolumeSnapshotConfigParam entity); Line 12: Line 13: public List<GlusterVolumeSnapshotConfigParam> getGlusterVolumeSnapshotConfigByClusterId(Guid clusterId); > getConfigByClusterId should do? ok. will change Line 14: Line 15: public List<GlusterVolumeSnapshotConfigParam> getGlusterVolumeSnapshotConfigByVolumeId(Guid clusterId, Guid volumeId); Line 16: Line 17: public GlusterVolumeSnapshotConfigParam getGlusterVolumeSnapshotConfigByClusterIdAndName(Guid clusterId, http://gerrit.ovirt.org/#/c/35303/8/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotConfigDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotConfigDaoDbFacadeImpl.java: Line 76: Line 77: protected MapSqlParameterSource createFullParametersMapper(GlusterVolumeSnapshotConfigParam config) { Line 78: return getCustomMapSqlParameterSource() Line 79: .addValue("cluster_id", config.getClusterId()) Line 80: .addValue("volume_id", config.getVolumeId()) > For cluster config, would volume_id be null? yes. thats how I am differentiating between cluster and volume configurations. Line 81: .addValue("param_name", config.getParamName()) Line 82: .addValue("param_value", config.getParamValue()); Line 83: } Line 84: -- To view, visit http://gerrit.ovirt.org/35303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0854984eed0f72226aa732a651be50bf8dda9fb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
