Moti Asayag has posted comments on this change. Change subject: engine: vm serialization test ......................................................................
Patch Set 1: (2 comments) The location is correct IMO. Common shouldn't be aware of serialization methods. http://gerrit.ovirt.org/#/c/36160/1/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/VmSerializationTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/VmSerializationTest.java: Line 6: import org.ovirt.engine.core.common.businessentities.VM; Line 7: Line 8: public class VmSerializationTest { Line 9: Line 10: VM vm = new VM(); private ? Line 11: Line 12: @Test Line 13: public void serializable() { Line 14: String serialized = new JsonObjectSerializer().serialize(vm); Line 12: @Test Line 13: public void serializable() { Line 14: String serialized = new JsonObjectSerializer().serialize(vm); Line 15: VM deserialized = new JsonObjectDeserializer().deserialize(serialized, VM.class); Line 16: assertEquals(vm, deserialized); any need to verify specific vm methods are called ? Line 17: } -- To view, visit http://gerrit.ovirt.org/36160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I643e8d1ce1ec570a305e3eb3ecfb5aa846fc1849 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
