Sahina Bose has posted comments on this change. Change subject: engine: Introduce HostValidator ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36157/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java: Line 21: private final StoragePoolDAO storagePoolDao; Line 22: private final VdsStaticDAO hostStaticDao; Line 23: private final VDS host; Line 24: Line 25: public HostValidator(DbFacade dbFacade, VDS host) { why have DbFacade as a parameter here? If it's to ease Junit, wouldn't a getDBFacade() do? Line 26: this.hostDao = dbFacade.getVdsDao(); Line 27: this.storagePoolDao = dbFacade.getStoragePoolDao(); Line 28: this.hostStaticDao = dbFacade.getVdsStaticDao(); Line 29: this.host = host; -- To view, visit http://gerrit.ovirt.org/36157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2256daf1de6a510c5b6ccb18846dd36bdc107f7d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
