Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: Replace UIConstants.empty()
......................................................................
Patch Set 3:
> One would think that, but all the changes are in UiCommon module which
> doesn't run that particular check style check.
Hm, in uicommonweb/pom.xml the NON-NLS check is enabled, unless I'm missing
something:
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<propertyExpansion>runNlsCheck=true</propertyExpansion>
</configuration>
</plugin>
I'd still advise to update this patch with NON-NLS comments.
--
To view, visit http://gerrit.ovirt.org/35894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17fac230cd19dd3513df06de355171430a823257
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
