Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Entities for gluster volume snapshot
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.ovirt.org/#/c/23199/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfigParam.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfigParam.java:

Line 2: 
Line 3: import org.ovirt.engine.core.common.businessentities.IVdcQueryable;
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5: 
Line 6: public class GlusterVolumeSnapshotConfigParam extends IVdcQueryable {
> rename to GlusterVolumeSnapshotConfig? Param suffix seems to indicate this 
sure. done
Line 7:     private static final long serialVersionUID = 3432543544365L;
Line 8:     private Guid clusterId;
Line 9:     private Guid volumeId;
Line 10:     private String paramName;


-- 
To view, visit http://gerrit.ovirt.org/23199
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Nishanth Thomas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to