Maor Lipchuk has posted comments on this change. Change subject: core: fix removal of attached disks to stateless vm ......................................................................
Patch Set 5: Code-Review+2 (3 comments) http://gerrit.ovirt.org/#/c/36035/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java: Line 66: List<DiskImage> statelessDiskSnapshots = getDiskSnapshotsForVmSnapshot(statelessVmSnapshotId); Line 67: Line 68: Guid activeVmSnapshotId = getVmSnapshotIdForType(SnapshotType.ACTIVE); Line 69: List<DiskImage> activeDiskSnapshots = getDiskSnapshotsForVmSnapshot(activeVmSnapshotId); Line 70: please remove redundant empty line Line 71: List<Guid> disksWithStatelessSnapshot = Entities.getIds(statelessDiskSnapshots); Line 72: Line 73: for (DiskImage activeDiskSnapshot : activeDiskSnapshots) { Line 74: if (!disksWithStatelessSnapshot.contains(activeDiskSnapshot.getId())) { Line 68: Guid activeVmSnapshotId = getVmSnapshotIdForType(SnapshotType.ACTIVE); Line 69: List<DiskImage> activeDiskSnapshots = getDiskSnapshotsForVmSnapshot(activeVmSnapshotId); Line 70: Line 71: List<Guid> disksWithStatelessSnapshot = Entities.getIds(statelessDiskSnapshots); Line 72: please remove redundant empty line Line 73: for (DiskImage activeDiskSnapshot : activeDiskSnapshots) { Line 74: if (!disksWithStatelessSnapshot.contains(activeDiskSnapshot.getId())) { Line 75: VdcReturnValueBase returnValue = runInternalAction ( Line 76: VdcActionType.DetachDiskFromVm, Line 90: return runInternalActionWithTasksContext(VdcActionType.RestoreAllSnapshots, Line 91: buildRestoreAllSnapshotsParameters(statelessDiskSnapshots), Line 92: getLock()).getSucceeded(); Line 93: } Line 94: please remove redundant empty line Line 95: return true; Line 96: } Line 97: Line 98: private Guid getVmSnapshotIdForType(SnapshotType type) { -- To view, visit http://gerrit.ovirt.org/36035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a1d6eb8d2f4606622c7ed5c73370792406bb9b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
