Maor Lipchuk has posted comments on this change. Change subject: core: Increment VM generation on disk update ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36059/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 125: performDiskUpdate(false); Line 126: List<Pair<VM, VmDevice>> vmsForDisk = getVmDAO().getVmsWithPlugInfo(getParameters().getDiskId()); Line 127: for (Pair<VM, VmDevice> pair : vmsForDisk) { Line 128: getVmStaticDAO().incrementDbGeneration(pair.getFirst().getId()); Line 129: } > We might not get to the end state if we only change the description. Moved the incremental to performDiskUpdate which is called also for async tasks at the end successfully Line 130: } finally { Line 131: freeLock(); Line 132: } Line 133: } -- To view, visit http://gerrit.ovirt.org/36059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f22beccb4479e246a19d800d18a3283d37534c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
