Martin Peřina has posted comments on this change.

Change subject: Host Power-Management Refactor (#977674)
......................................................................


Patch Set 42: Code-Review+1

(1 comment)

It looks good, just one unneeded empty line

http://gerrit.ovirt.org/#/c/27578/42/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java
File 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java:

Line 280: 
Line 281:     /**
Line 282:      * Ensures that the VDS instances are returned according to spm 
priority
Line 283:      */
Line 284: 
Please remove the empty line
Line 285:     @Test
Line 286:     public void testGetListForSpmSelection() {
Line 287:         final Guid STORAGE_POOL_ID = new 
Guid("6d849ebf-755f-4552-ad09-9a090cda105d");
Line 288:         List<VDS> result = 
dao.getListForSpmSelection(STORAGE_POOL_ID);


-- 
To view, visit http://gerrit.ovirt.org/27578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b384347a52db8b0aa6ae684fad40a5491dd2f7
Gerrit-PatchSet: 42
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to