Einav Cohen has posted comments on this change. Change subject: UI: change Make-Template to more readable text (#848104) ......................................................................
Patch Set 3: (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java Line 1645: AddVmTemplateParameters addVmTemplateParameters = Line 1646: new AddVmTemplateParameters(newvm, Line 1647: (String) model.getName().getEntity(), Line 1648: (String) model.getDescription().getEntity()); Line 1649: addVmTemplateParameters.setPublicUse(!(Boolean) model.getIsTemplatePublic().getEntity()); The above looks like a bug: setPublicUse(!getIsTemplatePublic). I would expect the following: setPublicUse(getIsTemplatePublic). [as it actually was before the code change] Not sure if this is only a variable-naming problem and the logic itself is correct, or something more (maybe the state before the code change was actually buggy - don't know); in any case - should be investigated and fixed - this is really confusing... Line 1650: Line 1651: addVmTemplateParameters.setDiskInfoDestinationMap( Line 1652: model.getDisksAllocationModel() Line 1653: .getImageToDestinationDomainMap((Boolean) model.getDisksAllocationModel() -- To view, visit http://gerrit.ovirt.org/7216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9055763d66b09da175810ad3ba2ace0ff8316264 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
