Moti Asayag has posted comments on this change. Change subject: core: Make Bookmark entity a JPA entity ......................................................................
Patch Set 27: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/33836/27/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java: Line 12: * pre-existing code from <code>DbFacade</code> Line 13: * Line 14: * Line 15: */ Line 16: @Singleton Isn't it problematic that the same entitymanager is shared between several threads ? http://stackoverflow.com/questions/13699201/handle-multiple-entitymanager-in-java-ee-application Line 17: public class BookmarkDAODbFacadeImpl extends HibernateFacade<Bookmark, Guid> implements BookmarkDAO { Line 18: Line 19: @Override Line 20: public Bookmark getByName(String name) { -- To view, visit http://gerrit.ovirt.org/33836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I162f1c22d32b16732ed50a7f6378f8d3e765141a Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
