Liron Aravot has posted comments on this change. Change subject: core: remove unneeded _newMasterStorageDomainId ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28442/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 69: return lockProperties.withScope(Scope.Execution); Line 70: } Line 71: Line 72: protected Guid getNewMasterId(boolean duringReconstruct) { Line 73: return (getNewMaster(duringReconstruct) == null) ? Guid.Empty : getNewMaster(duringReconstruct).getId(); I think that this change is risky, if on the first call to getNewMaster() we get null, proceed with the flow accordingly and on further call call a new master is selected(as domains status were changed) - the flow won't be "consistent". Line 74: } Line 75: Line 76: protected void setNewMaster(StorageDomain value) { Line 77: _newMaster = value; -- To view, visit http://gerrit.ovirt.org/28442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I592f77e2c583b8ea8360c60006a31bc5d62d3904 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
