Alon Bar-Lev has posted comments on this change.

Change subject: core, engine, userportal, webadmin: VirtIO console access key 
management
......................................................................


Patch Set 3:

without review code, the engine should not be aware of private key. user should 
paste public key into its record.

the information that is updated by user should be stored within different table 
not users, we can call it user preferences or user profile, in future user will 
be able to store locale, theme and other preferences as well.

marking as -1 as the private key is a serious violation of security.

-- 
To view, visit http://gerrit.ovirt.org/35810
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2364cafc687ba6dee2504322234067ff98dc00c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to