Ayal Baron has posted comments on this change.
Change subject: engine: Exception when updating lun disk properties (#844153)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 52:
Line 53: @Override
Line 54: public NGuid getStoragePoolId() {
Line 55: Disk d = getParameters().getDiskInfo();
Line 56: if (d instanceof DiskImage) {
The common way to check this in the backend is:
disk.getDiskStorageType() == DiskStorageType.IMAGE
I'm not saying it's better, just that it is the way most of the code uses (33
places vs. 4 for instanceof)
We should converge on one way and get rid of the other.
Line 57: return ((DiskImage) d).getstorage_pool_id().getValue();
Line 58: } else {
Line 59: return NGuid.Empty;
Line 60: }
--
To view, visit http://gerrit.ovirt.org/7230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba86289c25937002c9c07a06db5651bca4485d38
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
