Allon Mureinik has posted comments on this change. Change subject: core: getdisksvmguid hit the perf due to all_disks_including_snapshots view ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35787/3/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 301: l.device_size Line 302: FROM disk_lun_map dlm Line 303: JOIN luns l ON l.lun_id = dlm.lun_id Line 304: LEFT JOIN vms_for_disk_view on vms_for_disk_view.device_id = dlm.disk_id Line 305: group by dlm.disk_id, vms_for_disk_view.entity_type, l.lun_id, l.physical_volume_id, l.volume_group_id, l.serial, l.lun_mapping, l.vendor_id, l.product_id, l.device_size, vms_for_disk_view.array_vm_names The group by here is redundant. dlm.disk_id is unique even after the joins, and cannot be duplicated with image_guid from above. Line 306: ) AS storage_impl Line 307: JOIN base_disks bd ON bd.disk_id = storage_impl.image_group_id; Line 308: Line 309: CREATE OR REPLACE VIEW all_disks -- To view, visit http://gerrit.ovirt.org/35787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I076e804cab601f3873cf2fdccba77abe42da60d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
