Eli Mesika has posted comments on this change. Change subject: engine: DB persistent quartz scheduler ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/36297/3/packaging/dbscripts/upgrade/03_06_0590_insert_quartz_tables.sql File packaging/dbscripts/upgrade/03_06_0590_insert_quartz_tables.sql: Line 19: ( Line 20: sched_name VARCHAR(120) NOT NULL, Line 21: job_name VARCHAR(200) NOT NULL, Line 22: job_group VARCHAR(200) NOT NULL, Line 23: description VARCHAR(250) NULL, Please consider text as datatype since description might be log and PG will not truncate the information, rather , it will reject the insert/update This is especially true for UNICODE in which we may have double-byte characters so the actual length will be only 125 Line 24: job_class_name VARCHAR(250) NOT NULL, Line 25: is_durable BOOL NOT NULL, Line 26: is_nonconcurrent BOOL NOT NULL, Line 27: is_update_data BOOL NOT NULL, Line 36: trigger_name VARCHAR(200) NOT NULL, Line 37: trigger_group VARCHAR(200) NOT NULL, Line 38: job_name VARCHAR(200) NOT NULL, Line 39: job_group VARCHAR(200) NOT NULL, Line 40: description VARCHAR(250) NULL, same Line 41: next_fire_time BIGINT NULL, Line 42: prev_fire_time BIGINT NULL, Line 43: priority INTEGER NULL, Line 44: trigger_state VARCHAR(16) NOT NULL, -- To view, visit http://gerrit.ovirt.org/36297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
