Liron Aravot has posted comments on this change. Change subject: core: Add alias and description for disk meta data ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/34163/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 356: } Line 357: Line 358: private void performDiskUpdate(final boolean unlockImage) { Line 359: if (shouldPerformMetadataUpdate()) { Line 360: updateMetaDataDescription((DiskImage) getNewDisk()); > The reason we lock the image in the DB is simply to make it persistent so i The reason that we lock in the db is also for user experience, it's frustrating for the user that there is long running operation while the status appear as OK in the UI (for example - take storage domain operations..there are no created tasks and we still change the status). The UI issue does exist for extend, but now we are "extending" the bug to potentialy six minutes (set volume description + extend)..so i'm not sure about this part - I'd fix it as part of this change to not make it more of an issue. if Allon thinks that this is the correct approach, feel free to continue with it as is - imo it should be changed. Line 361: } Line 362: final Disk disk = getDiskDao().get(getParameters().getDiskId()); Line 363: applyUserChanges(disk); Line 364: -- To view, visit http://gerrit.ovirt.org/34163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
