Tal Nisan has posted comments on this change. Change subject: core: Storage validator packaging. ......................................................................
Patch Set 3: (2 comments) Minor issues, fix them and it's a go http://gerrit.ovirt.org/#/c/36286/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java: Line 10: import static org.mockito.Mockito.when; Line 11: Line 12: import java.util.ArrayList; Line 13: import java.util.HashSet; Line 14: import java.util.List; This class should be a part of this patch Line 15: import java.util.Set; Line 16: Line 17: import org.junit.Before; Line 18: import org.junit.ClassRule; http://gerrit.ovirt.org/#/c/36286/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java: Line 33: import org.ovirt.engine.core.compat.Guid; Line 34: import org.ovirt.engine.core.dao.StorageDomainDAO; Line 35: import org.ovirt.engine.core.utils.MockConfigRule; Line 36: Line 37: /** A test class for the MultipleStorageDomainsValidator class. */ Why did you remove the link? Line 38: @RunWith(MockitoJUnitRunner.class) Line 39: public class MultipleStorageDomainsValidatorTest { Line 40: Line 41: @ClassRule -- To view, visit http://gerrit.ovirt.org/36286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacc2a20be1ba12864b5d567d902f9245a05c374f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
