Eli Mesika has posted comments on this change. Change subject: core: fix search on fedora 21 ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/36282/3/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java: Line 166: relations = getLikeSyntax(caseSensitive); Line 167: } else if ("!=".equals(relations)) { Line 168: relations = "NOT " + getLikeSyntax(caseSensitive); Line 169: } Line 170: // Sort according to the value (real column name) in order not to rely on random access from map > instead of doing this step, can't we just define the columnNameDict to be t I prefer to leave that as is since getDbFieldName is using this .... Line 171: SortedSet<Map.Entry<String, String>> sortedEntrySet = new TreeSet<>(new ColNameMapEntryComparator()); Line 172: for (Map.Entry<String, String> entry : columnNameDict.entrySet()) { Line 173: sortedEntrySet.add(entry); Line 174: } Line 170: // Sort according to the value (real column name) in order not to rely on random access from map Line 171: SortedSet<Map.Entry<String, String>> sortedEntrySet = new TreeSet<>(new ColNameMapEntryComparator()); Line 172: for (Map.Entry<String, String> entry : columnNameDict.entrySet()) { Line 173: sortedEntrySet.add(entry); Line 174: } > can't you use addAll instead of iterating? That was my intention on patch #1 but findbugs claims that using addAll may lead to unexpected results so I had to change my code and iterate Line 175: for (Map.Entry<String, String> columnNameEntry : sortedEntrySet) { Line 176: if (typeDict.get(columnNameEntry.getKey()) == String.class && !notFreeTextSearchableFieldsList.contains(columnNameEntry.getKey())) { Line 177: if (firstTime) { Line 178: firstTime = false; -- To view, visit http://gerrit.ovirt.org/36282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e6f2cb0832dc21be9fab9f24858e6f7c4c613ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
