Allon Mureinik has posted comments on this change. Change subject: core: AddStorageDomainCommand CDA addition ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36393/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-24 18:18:03 +0200 Line 4: Commit: Amit Aviram <[email protected]> Line 5: CommitDate: 2014-12-24 19:31:46 +0200 Line 6: Line 7: core: AddStorageDomainCommand CDA addition The subject should describe WHAT the patch does, e.g.: "core: Prevent Export domains on block storage" Line 8: Line 9: Block domains does not support export type. Thus a validation was added Line 10: in AddStorageDomainCommand CDA. Line 11: -- To view, visit http://gerrit.ovirt.org/36393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f68c866e583152b80780554f5529eb720e0759 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
