Daniel Erez has posted comments on this change. Change subject: webadmin: Warn when importing a data domain to a DC that doesn't support ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36328/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java: Line 348 Line 349 Line 350 Line 351 Line 352 > I actually thought about it but it seemed a but overkill to me, will ask Da If it won't require too much re-factoring then add a 'getDataCenterAlertMessage' method and a 'shouldShowDataCenterAlert' method; otherwise you can add it in a following clean-up patch. -- To view, visit http://gerrit.ovirt.org/36328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79e57dc3d2bcc8a3efb717f0261d9ca66636b463 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
