Maor Lipchuk has posted comments on this change. Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32383/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java: Line 110: } Line 111: Line 112: private static void setInterfaceProperties(StorageServerConnections conn, VdsNetworkInterface iface) { Line 113: conn.setIface(iface.getName()); Line 114: conn.setNetIfaceName(iface.isBridged() ? iface.getNetworkName() : iface.getName()); > Can we move this to StorageServerConnections? StorageServerConnections is a business entity, it should not maintain logic methods such as this once this code will be used again, then we might think of a good place to make it reusable depending on the case. Line 115: } Line 116: Line 117: @SuppressWarnings("unchecked") Line 118: @Override -- To view, visit http://gerrit.ovirt.org/32383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2f3549fa08741f719eeb8d70209ab298e09da3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
