Arik Hadas has uploaded a new change for review. Change subject: core: cleanup in SnapshotVDSCommand ......................................................................
core: cleanup in SnapshotVDSCommand Replace explicit strings with VdsProperties constants. Change-Id: I7d2db7c68264ad0d8cbd313be39eec1f454eb01f Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 2 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/36426/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java index d3c01cc..80ee2b8 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java @@ -39,10 +39,10 @@ for (int i = 0; i < result.length; i++) { DiskImage image = getParameters().getImages().get(i); Map<String, String> imageParams = new HashMap<String, String>(); - imageParams.put("domainID", image.getStorageIds().get(0).toString()); - imageParams.put("imageID", image.getimage_group_id().toString()); - imageParams.put("baseVolumeID", image.getParentId().toString()); - imageParams.put("volumeID", image.getImageId().toString()); + imageParams.put(VdsProperties.DomainId, image.getStorageIds().get(0).toString()); + imageParams.put(VdsProperties.ImageId, image.getimage_group_id().toString()); + imageParams.put(VdsProperties.BaseVolumeId, image.getParentId().toString()); + imageParams.put(VdsProperties.VolumeId, image.getImageId().toString()); result[i] = imageParams; } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java index c92b83b..795822c 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java @@ -306,6 +306,7 @@ public static final String DomainId = "domainID"; public static final String ImageId = "imageID"; public static final String VolumeId = "volumeID"; + public static final String BaseVolumeId = "baseVolumeID"; public static final String Format = "format"; public static final String Shareable = "shared"; public static final String None = "none"; -- To view, visit http://gerrit.ovirt.org/36426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d2db7c68264ad0d8cbd313be39eec1f454eb01f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
