Arik Hadas has posted comments on this change. Change subject: core: supress findbugs warning in StorageServerConnectionCommandBase ......................................................................
Patch Set 2: it doesn't matter that FCP has no connections, the question is whether isConnWithSameDetailsExists can be called when the storage type is FCP. I'm not familiar with this code, so if there is such a flow, then this solution doesn't cover it. I think that adding null-check is not too much noise.. -- To view, visit http://gerrit.ovirt.org/36430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I139f33ddba33cfb109145505afc1aea609c82807 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
