Shubhendu Tripathi has posted comments on this change. Change subject: engine : Geo-rep config Vds Commands ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/35972/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java: Line 24: protected StatusForXmlRpc getReturnStatus() { Line 25: return result.mStatus; Line 26: } Line 27: Line 28: public Map<String, GlusterGeoRepSessionConfiguration> prepareMapOfExistingConfigs(List<GlusterGeoRepSessionConfiguration> existingConfigs) { Do we need this method to be public? Line 29: Map<String, GlusterGeoRepSessionConfiguration> resultantMap = new HashMap<>(); Line 30: if (existingConfigs != null) { Line 31: for (GlusterGeoRepSessionConfiguration config : existingConfigs) { Line 32: resultantMap.put(config.getKey(), config); -- To view, visit http://gerrit.ovirt.org/35972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I558ed18b94faae9d4b824c9de1fedda25ffc3f09 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
