Yedidyah Bar David has posted comments on this change. Change subject: utils: RedirectServlet: replace localhost to engine host ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/35885/6/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java: Line 42: private static final Set localHostNames = new HashSet(Arrays.asList( Line 43: "localhost", Line 44: "localhost.localdomain", Line 45: "localhost6", Line 46: "localhost6.localdomain" > ok, added... Gentoo simply have localhost for both :) > and again, it is not important what in /etc/hosts, as we control the value in > setup... I agree about the reports redirect. But this code is general, not sure what else it's used for now, and especially what it will be used for in the future. That's why I preferred to make it configurable. BTW, not sure how much you care about users inputting 'localhost' or 'localhost.localdomain' to the 'fqdn' question - especially with separate hosts for engine/reports. As iirc I already said before - this check for the string 'localhost' (even with variants) is a hack, I do not like it. Line 47: )); Line 48: Line 49: private String targetUrl; Line 50: private String url404; -- To view, visit http://gerrit.ovirt.org/35885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155489de230124339be4f2493686c83ebaee3a68 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
