Moti Asayag has posted comments on this change.
Change subject: engine: Add validation that network exists (#743830)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
Line 103: }
Line 104:
Line 105: @Override
Line 106: protected boolean canDoAction() {
Line 107: return super.canDoAction() && VdsGroupExists() &&
logicalNetworkExists() && changesAreClusterCompatible();
how about moving logicalNetworkExists() after changesAreClusterCompatible() ?
in case changesAreClusterCompatible() returns false, it will save one DB call :)
Line 108: }
Line 109:
Line 110: private boolean logicalNetworkExists() {
Line 111: if
(getNetworkDAO().get(getParameters().getNetworkCluster().getnetwork_id()) !=
null) {
--
To view, visit http://gerrit.ovirt.org/7333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f4908cfca5fc282512ad245f7b4f458f450113f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
