Maor Lipchuk has posted comments on this change.

Change subject: core: Add vdc query for import File Storage Domain
......................................................................


Patch Set 5:

(1 comment)

> Why do we need this in addition to the query in the previous patch?
Since one is for attach (in the previous patch which also do connect and 
disconnect, and another is for import

http://gerrit.ovirt.org/#/c/36448/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java:

Line 377:     GetAffinityGroupById,
Line 378:     GetAffinityGroupsByClusterId,
Line 379:     GetAffinityGroupsByVmId,
Line 380: 
Line 381: 
> reduntant
done
Line 382:     GetAllDisksPartialDataByVmId(VdcQueryAuthType.User),
Line 383:     GetVmTemplateCount,
Line 384: 
Line 385:     //Disk Profiles


-- 
To view, visit http://gerrit.ovirt.org/36448
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63a90b86b8427bd6128becccf83be7204637e611
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to