Maor Lipchuk has posted comments on this change. Change subject: core: Add vdc query for attached Storage Domain ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/36447/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java: Line 92: VDSReturnValue vdsReturnValue = null; Line 93: List<StorageDomainStatic> storageDomainsWithAttachedStoragePoolId = new ArrayList<>(); Line 94: Line 95: // Go over the list of Storage Domains and try to get the Storage Domain info to check if it is attached to Line 96: // another > reformat comment done Line 97: // Storage Pool Line 98: for (StorageDomain storageDomain : storageDomains) { Line 99: try { Line 100: vdsReturnValue = http://gerrit.ovirt.org/#/c/36447/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java: Line 39: Line 40: private StorageDomain storageDomain; Line 41: Line 42: @Before Line 43: public void setup() { > setUp? why? how come setup is not better? done Line 44: storageDomain = new StorageDomain(); Line 45: storageDomain.setStorageName("Name of Storage"); Line 46: storageDomain.setStorageType(StorageType.ISCSI); Line 47: http://gerrit.ovirt.org/#/c/36447/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainsAndStoragePoolIdQueryParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainsAndStoragePoolIdQueryParameters.java: Line 11: private List<StorageDomain> storageDomainList; Line 12: private StorageServerConnections storageServerConnection; Line 13: private Guid vdsId; Line 14: Line 15: public List<StorageDomain> getStorageDomainList() { > please move *all* getters/setters to bottom... done Line 16: return storageDomainList; Line 17: } Line 18: Line 19: public void setStorageDomainIdList(List<StorageDomain> storageDomainList) { -- To view, visit http://gerrit.ovirt.org/36447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I749cad223d90dcc8d193765ed842d7e062ad566c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
