Amit Aviram has posted comments on this change. Change subject: core: UpdateStorageServerConnectionCommandTest refactor. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36479/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java: Line 713: assertFalse(isExists); Line 714: } Line 715: Line 716: private void initDomainListForConnection(String connId, StorageDomain... domains) { Line 717: doReturn(Arrays.asList(domains)).when(command).getStorageDomainsByConnId(connId); > Use Collections.singletonList instead of Attays.asList Notice I'm getting an array of domains here (StorageDomain ... domains), and getStorageDomainsByConnId should return a List of those domains- so I'll need to create that list. Collections.singletonList expects to get only one domain while Arrays.asList creates a List referencing the array sent. Line 718: } Line 719: Line 720: protected ConnectStorageToVdsCommand getCommand() { Line 721: return command; -- To view, visit http://gerrit.ovirt.org/36479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I417b5b1a3771ecc31dc121de12f7e5be6de6662b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
