Sahina Bose has posted comments on this change. Change subject: gluster: VDS Command - Delete gluster vol snapshot ......................................................................
Patch Set 5: Code-Review+1 (3 comments) Minor comments http://gerrit.ovirt.org/#/c/34771/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 299 Line 300 Line 301 Line 302 Line 303 This file required? http://gerrit.ovirt.org/#/c/34771/5/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 839: Line 840: @DefaultStringValue("Gluster snapshot create failed") Line 841: String GlusterSnapshotCreateFailedException(); Line 842: Line 843: @DefaultStringValue("Gluster snapshot delete failed") Failed to delete gluster volume snapshot ? Line 844: String GlusterSnapshotDeleteFailedException(); http://gerrit.ovirt.org/#/c/34771/5/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties: Line 382: GlusterVolumeRebalanceStatusFailedException=Failed to get gluster volume rebalance status Line 383: GlusterVolumeRemoveBrickStatusFailed=Failed to get status of gluster volume remove bricks Line 384: GlusterSnapshotException=Gluster Snapshot Exception Line 385: GlusterSnapshotCreateFailedException=Gluster snapshot create failed Line 386: GlusterSnapshotDeleteFailedException=Gluster snapshot delete failed same suggestion as previous file -- To view, visit http://gerrit.ovirt.org/34771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I968ba8242ab2a8a84e339b22fdc001c4607ac929 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
