Tal Nisan has posted comments on this change. Change subject: core: Adding a pool with vm storage allocation ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36553/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java: Line 134: List<DiskImage> disksList = new ArrayList<>(); Line 135: // Number of added disks multiplies by the vms number Line 136: for (int i = 0; i < numOfVms; ++i) { Line 137: disksList.addAll(diskInfoDestinationMap.values()); Line 138: } Please remove this part Line 139: // At this point the disks are the template's, which could have another volume type/format Line 140: // This change is for storage allocation validations, "real" override for these values is done in CreateSnapshotCommand. Line 141: /*for (DiskImage diskImage : disksList) { Line 142: diskImage.setVolumeType(VolumeType.Sparse); -- To view, visit http://gerrit.ovirt.org/36553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46bef12bbc0462bb42956f95bdff1855631e7b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
