Martin Mucha has posted comments on this change. Change subject: core: Make DAOs injectable ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/35793/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HibernateFacade.java: Line 10: import javax.persistence.Query; Line 11: Line 12: /** Line 13: * A shared class for all DaoFacades that use Hibernate. Note that our code does not expect to work with attached Line 14: * entities, so returned entities are detached. There is an API for working with attached entities. > Done Maybe I'm just not following you, but how was this resolved? By that replacing persist—>merge? Is that even correct? I don't know, merge just places entity to persistence context, which may cause that it will be persisted if it's not existing, but why not call persist then in first place, if that's operation intended for that? Line 15: * @author lzelkha Line 16: * @param <T> Line 17: * The entity Line 18: * @param <K> -- To view, visit http://gerrit.ovirt.org/35793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia408a878fa0fa8dd8b414a60683c36d0db6d6641 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
