Juan Hernandez has posted comments on this change. Change subject: cli: Allow any string as parent identifier ......................................................................
Patch Set 1: I guess that you mean a situation like this: The entity I want to use: id=ignore name=a0123 Another entity: id=a0123 name=ignore In this case, if the user intends to use the first entity and he types "--whatever-identifier a0123" he will actually be using the second one. This is something that may happen, but chances are low, in my opinion. Note that this can also happen before this change, as nothing prevents assigning to an entity a name that is actually an UUID. The only solution I see to this potential problem is to lookup parents only by id, and not by name, but that would break backwards compatibility. Any suggestion? -- To view, visit http://gerrit.ovirt.org/36535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438e0d5e3c29302fda63e0f0ab01e87a6841e10e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
