Einav Cohen has posted comments on this change. Change subject: WIP: new Tooltip infrastructure ......................................................................
Patch Set 3: > times are configurable. Fading in/out is by design. I think the current > implementation where it instantly opens at you is harsh / scary. Although in the PatternFly demo immediate opening and closing looks OK (https://www.patternfly.org/widgets/#tooltip), I tend to agree with you on immediately opening, which may be overwhelming. I think for opening, we should wait ~0.5 second but closing should be done immediately (or with a delay much shorter than 0.5 second) - similar to native browser tool-tips behavior in the application today - see https://raw.githubusercontent.com/eco-public/clipboard/master/out.ogv > > two tool-tips may appear at the same time. > is that a problem? I think it is, however it is more painful if the tool-tips are lingering as they are right now (in some cases, e.g. towards the end of the previous screen-cast that I posted); if the tool-tips will disappear quickly enough, it may not be a problem anymore. > 1 second is by design (https://bugzilla.redhat.com/show_bug.cgi?id=1023549) > if they take longer, it's because a grid refresh happened. currently i have > the reaper set to 5 seconds or something, but we could have it shorter or > even near-instant. I think that the current 5-seconds lingering is somewhat disrupting the user experience; as I mentioned above - we should aim towards closing the tooltips immediately or after an extremely short delay; however, we need to make sure that the frequent timers in the code are not causing any issues to the GUI behavior/performance, so we may need to balance things out eventually somehow. Please proceed with fixing the issues (rather than resorting to native browser tool-tips, as I suggested earlier). Thanks. -- To view, visit http://gerrit.ovirt.org/36530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f82efada76f8b4654f034c428246f27ebe55889 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
