Eli Mesika has posted comments on this change. Change subject: core: Adding 3.6 support ......................................................................
Patch Set 5: -Verified (3 comments) http://gerrit.ovirt.org/#/c/36518/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java: Line 67: mockConfig(ConfigValues.SupportedStorageFormats, Version.v3_2.toString(), "3"), Line 68: mockConfig(ConfigValues.SupportedStorageFormats, Version.v3_3.toString(), "3"), Line 69: mockConfig(ConfigValues.SupportedStorageFormats, Version.v3_4.toString(), "3"), Line 70: mockConfig(ConfigValues.SupportedStorageFormats, Version.v3_5.toString(), "3"), Line 71: mockConfig(ConfigValues.SupportedStorageFormats, Version.v3_6.toString(), "3"), > This config value (SupportedStorageFormats) is actually removed in another I don't agree on that, either this patch or the other , the last should be rebased and corrected accordingly, we are not inserting changed based on future commits ! Line 72: mockConfig(ConfigValues.GlusterFsStorageEnabled, Version.v3_0.toString(), false), Line 73: mockConfig(ConfigValues.GlusterFsStorageEnabled, Version.v3_4.toString(), true), Line 74: mockConfig(ConfigValues.GlusterFsStorageEnabled, Version.v3_5.toString(), true), Line 75: mockConfig(ConfigValues.GlusterFsStorageEnabled, Version.v3_6.toString(), true), http://gerrit.ovirt.org/#/c/36518/5/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 465: select fn_db_add_config_value('HostStorageConnectionAndPoolRefreshTimeInSeconds','30','general'); Line 466: select fn_db_add_config_value('SucceededJobCleanupTimeInMinutes','10','general'); Line 467: select fn_db_add_config_value('SupportedClusterLevels','3.0','general'); Line 468: select fn_db_add_config_value('SupportedStorageFormats','0,2','3.0'); Line 469: select fn_db_add_config_value_for_versions_up_to('SupportedStorageFormats', '0,2,3','3.6'); > See comment regarding this config value in StorageHandlingCommandBaseTest Done Line 470: select fn_db_add_config_value('SupportedVDSMVersions','4.9,4.10,4.11,4.12,4.13,4.14','general'); Line 471: Line 472: select fn_db_add_config_value('SupportForceCreateVG','false','3.0'); Line 473: select fn_db_add_config_value_for_versions_up_to('SupportForceExtendVG', 'false','3.1'); Line 767: select fn_db_update_config_value('ServerCPUList','3:Intel Conroe Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 7:Intel SandyBridge Family:vmx,nx,model_SandyBridge:SandyBridge:x86_64; 8:Intel Haswell Family:vmx,nx,model_Haswell:Haswell:x86_64; 2:AMD Opteron G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64; 5:AMD Opteron G4:svm,nx,model_Opteron_G4:Opteron_G4:x86_64; 6:AMD Opteron G5:svm,nx,model_Opteron_G5:Opteron_G5:x86_64; 3:IBM POWER 8:powernv,model_power8:power8:ppc64;','3.5'); Line 768: select fn_db_update_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.3'); Line 769: select fn_db_update_config_value('SpiceDriverNameInGuest','{"windows": "RHEV-Spice", "linux" : "xorg-x11-drv-qxl" }','general'); Line 770: select fn_db_update_config_value('SupportedClusterLevels','3.0,3.1,3.2,3.3,3.4,3.5,3.6','general'); Line 771: select fn_db_update_config_value('SupportedStorageFormats','0,2,3','3.1,3.2,3.3,3.4,3.5,3.6'); > See comment regarding this config value in StorageHandlingCommandBaseTest Done Line 772: select fn_db_update_config_value('SupportedVDSMVersions','4.9,4.10,4.11,4.12,4.13,4.14,4.15,4.16','general'); Line 773: select fn_db_update_config_value('VdcVersion','3.6.0.0','general'); Line 774: select fn_db_update_config_value('ProductRPMVersion','3.6.0.0','general'); Line 775: select fn_db_update_config_value('VdsFenceOptionMapping','alom:secure=secure,port=ipport;apc:secure=secure,port=ipport,slot=port;bladecenter:secure=secure,port=ipport,slot=port;drac5:secure=secure,port=ipport;eps:slot=port;ilo:secure=ssl,port=ipport;ipmilan:;rsa:secure=secure,port=ipport;rsb:;wti:secure=secure,port=ipport,slot=port','3.0'); -- To view, visit http://gerrit.ovirt.org/36518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7354f13aabc27f0306afd4f1d2be54f9e71126a1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
