Yaniv Bronhaim has posted comments on this change. Change subject: Update only name and address fields when picking foreman parameters ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36550/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 98: ExternalHostGroup dhg = (ExternalHostGroup) getExternalHostGroups().getSelectedItem(); Line 99: if (dhost != null && dhg != null) { Line 100: setOriginalName(dhost.getName()); Line 101: getName().setEntity(dhost.getName()); Line 102: getHost().setEntity(dhost.getName() + "." + dhg.getDomainName()); //$NON-NLS-1$ > Is that intentional to remove check for dhg.getDomainName() is null. We wou no! thanks!!!! Line 103: } Line 104: } Line 105: } Line 106: -- To view, visit http://gerrit.ovirt.org/36550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eadb533dd02698f07103fa61e076b46d054522 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
