Juan Hernandez has posted comments on this change.
Change subject: restapi: update REST API to pass managementNetworkId on cluster
creation
......................................................................
Patch Set 21: Code-Review-1
The set of roles of a network are an attribute of the relationship between the
cluster and the network. As networks are dependent entities this is already
represented as part of the network entity:
GET /clusters/{cluster:id}/networks/{network:id}
<network>
...
<usages>
<usage>display</usage>
<usage>migration</usage>
...
</usages>
</network>
So, in my opinion, specifying this as part of the cluster entity is redundant
and not necessary.
If we eventually add this kind of redundant specification the XML should be
modelled like other references to entities, using the "id" or "name" attributes:
<cluster>
...
<management_network id="{network:id}" href="..."/>
...
</cluster>
Or:
<cluster>
...
<management_network>
<name>{network:name}</name>
</management_network>
...
</cluster>
--
To view, visit http://gerrit.ovirt.org/33502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3159ef098730940df15bc43019139e120aec8b
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
