Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Frontend improvements ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36536/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/jsni/JsSingleValueObject.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/jsni/JsSingleValueObject.java: Line 4: Line 5: /** Line 6: * Overlay for JS object containing single {@code value} property, e.g. <code>{ value: anything }</code> Line 7: */ Line 8: public abstract class JsSingleValueObject extends JavaScriptObject { Two white spaces, I missed that, lol :-) Line 9: Line 10: protected JsSingleValueObject() { Line 11: } Line 12: Line 9: Line 10: protected JsSingleValueObject() { Line 11: } Line 12: Line 13: public static native String getValueAsString(String objName) /*-{ > Should we have a couple of default type helper functions like: Well, so far we only have String-typed single-value JS objects (ssoToken, baseContextPath, visibleLocales, engineSessionTimeout, <new> engineRpmVersion, applicationMode). This is why there's only the "getValueAsString" method. Any other JS objects (userInfo, messages, pluginDefinitions, engineReportsUrls) are Object-typed, and have their own specific GWT overlay types (for example, AutoLoginData or SSOTokenData). I agree with your suggestion, we can just call this class JsSingleValueStringObject and rename its method to getValue. Line 14: var obj = $wnd[objName]; Line 15: return obj && obj.value; Line 16: }-*/; Line 17: -- To view, visit http://gerrit.ovirt.org/36536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4864b2d4703ee548a570799ed3e87674602f5438 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
