Michael Pasternak has posted comments on this change.
Change subject: restapi: Add enum validations
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
Line 91:
Line 92: protected ValidatorLocator getValidatorLocator() {
Line 93: if (validatorLocator == null) {
Line 94: validatorLocator = new ValidatorLocator();
Line 95: validatorLocator.populate();
you do not need creating new instance of validatorLocator for every new
sub-resource/subcollection, you can reuse instance defined in
BackendApplication by adding [resource.setValidatorLocator(X);] in
AbstractBackendResource.inject(). - it used to inject context ('backend', etc.)
in to every sub-resource/subcollection,
Line 96: }
Line 97: return validatorLocator;
Line 98: }
Line 99:
--
To view, visit http://gerrit.ovirt.org/7218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32b575589a7c82cb2d9e6da8d4d852a50f0f595f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
