Daniel Erez has posted comments on this change. Change subject: webadmin: Configurable Default for Wipe After Delete per Storage Domain ......................................................................
Patch Set 5: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/36526/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageDomainWipeAfterDeleteQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageDomainWipeAfterDeleteQuery.java: Line 9: public GetStorageDomainWipeAfterDeleteQuery(P parameters) { Line 10: super(parameters); Line 11: } Line 12: Line 13: @Override protected void executeQueryCommand() { style - move the '@Override' annotation to a separate line above Line 14: if (getParameters().getStorageType() != null) { Line 15: getQueryReturnValue().setReturnValue( Line 16: WipeAfterDeleteUtils.getDefaultWipeAfterDeleteFlag(getParameters().getStorageType())); Line 17: } http://gerrit.ovirt.org/#/c/36526/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml: Line 6: Line 7: <ui:with field='resources' type='org.ovirt.engine.ui.webadmin.ApplicationResources' /> Line 8: <ui:style type="org.ovirt.engine.ui.webadmin.section.main.view.popup.storage.StoragePopupView.WidgetStyle"> Line 9: .content { Line 10: overflow-x: hidden; > I tried it again without it, but then if you choose Data/iSCSI on the Impor ok, let's leave it this way for now Line 11: } Line 12: Line 13: .formatContentWidget { Line 14: width: 80px; -- To view, visit http://gerrit.ovirt.org/36526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bf6a95eb4b33867de86e99f8cb59eec0d1cdd4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
