Maor Lipchuk has posted comments on this change. Change subject: core: iSCSI multipath sub tab when SD is in maintenance. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36667/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetConnectionsByDataCenterAndStorageTypeQuery.java: Line 16: @Override Line 17: protected void executeQueryCommand() { Line 18: getQueryReturnValue().setReturnValue( Line 19: getDbFacade().getStorageServerConnectionDao() Line 20: .getStorageConnectionsByStorageTypeAndStatus(getParameters().getId(), > getStorageConnectionsByStorageType is a horrible method that contains busin I know, I was thinking about many ways to solve this. Thinking about this again, probably the most best way to solve this is to use getAll on the Storage Pool and filter the iSCSI Storage Domains. That will make GetConnectionsByDataCenterAndStorageTypeQuery + getStorageServerConnectionDao#getConnectableStorageConnectionsByStorageType(Guid, StorageType) redundant... How that solution sounds? Line 21: getParameters().getStorageType(), Line 22: EnumSet.of(StorageDomainStatus.Active, Line 23: StorageDomainStatus.Inactive, Line 24: StorageDomainStatus.Unknown, -- To view, visit http://gerrit.ovirt.org/36667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafaa1010f500dc7c0ec71863fc20127d525bc4ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
