Alon Bar-Lev has posted comments on this change. Change subject: packaging: spec: fix java-openjdk requirements ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36303/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 219: Requires: %{name}-webadmin-portal = %{version}-%{release} Line 220: Requires: %{name}-websocket-proxy >= %{version}-%{release} Line 221: Requires: fop Line 222: Requires: java Line 223: Requires: java-openjdk >= 1:1.7.0.9-2.3.3.2 > The requires section just pull in 1.7 in el6, el7 and fc20 and pull in 1.8 maybe I missed something but it never worked for me properly, but maybe they changed something in rhel-6.6 Line 224: Requires: jpackage-utils Line 225: Requires: ovirt-image-uploader >= 3.6.0 Line 226: Requires: ovirt-iso-uploader >= 3.6.0 Line 227: Requires: patternfly1 Line 265: # of the update process implemented in the engine-upgrade script: Line 266: Requires: %{name}-setup >= %{version}-%{release} Line 267: Line 268: # rhbz#1028966 Line 269: Conflicts: java-openjdk = 1:1.7.0.45-2.4.3.3.el6 > Looking better at this, why not just require right, no need for this conflict. Line 270: Line 271: # We can drop these conflicts when Line 272: # we drop Requires: mod_ssl Line 273: Conflicts: freeipa-server -- To view, visit http://gerrit.ovirt.org/36303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I429f7fffbb551241748b867b9c456c0733ccc705 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
