Vojtech Szocs has uploaded a new change for review. Change subject: webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs ......................................................................
webadmin,userportal: Remove general JVM settings from gwt-plugin.extraJvmArgs JVM settings defined in "gwt-plugin.extraJvmArgs" Maven property apply to GWT compiler main Java process (which spawns worker threads due to using ThreadedPermutationWorkerFactory). These JVM settings *will* override any global JVM settings, such as the ones defined via MAVEN_OPTS environment variable. This leads to problems when trying to customize *some* of settings defined in "gwt-plugin.extraJvmArgs" Maven property. This patch removes all general (non-GWT) JVM settings from this property: a, JVM memory related: -Xms -Xmx8192M -XX:PermSize -XX:MaxPermSize b, Java I/O & Preference subsystem related: -Djava.io.tmpdir -Djava.util.prefs.systemRoot -Djava.util.prefs.userRoot Above mentioned JVM settings should be defined per environment via MAVEN_OPTS environment variable. Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908 Signed-off-by: Vojtech Szocs <[email protected]> --- M frontend/webadmin/modules/pom.xml 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/36739/1 diff --git a/frontend/webadmin/modules/pom.xml b/frontend/webadmin/modules/pom.xml index 757a0af..a49d636 100644 --- a/frontend/webadmin/modules/pom.xml +++ b/frontend/webadmin/modules/pom.xml @@ -43,13 +43,10 @@ <!-- Regular expression that matches types that GWT compiler shouldn't prune (avoid dead code optimization) --> <gwt.dontPrune>-Dgwt.dontPrune=org\.ovirt\.engine\.core\.(common|compat)\..*</gwt.dontPrune> <!-- This can be overridden by setting this property in your personal settings.xml --> + <!-- Please use MAVEN_OPTS to define JVM memory settings like -Xms and -Xmx --> <gwt-plugin.extraJvmArgs> - -Xms1024M -Xmx8192M -XX:PermSize=512M -XX:MaxPermSize=1024M \ -Dgwt.jjs.permutationWorkerFactory=com.google.gwt.dev.ThreadedPermutationWorkerFactory \ - -Dgwt.jjs.maxThreads=4 \ - -Djava.io.tmpdir="${project.build.directory}/tmp" \ - -Djava.util.prefs.systemRoot="${project.build.directory}/tmp/.java" \ - -Djava.util.prefs.userRoot="${project.build.directory}/tmp/.java" + -Dgwt.jjs.maxThreads=4 </gwt-plugin.extraJvmArgs> <!-- Control target browsers for GWT compilation, maps to 'user.agent' deferred binding property in *.gwt.xml --> <!-- By default, compile for Firefox browser only, use 'all-user-agents' profile to compile for all browsers --> -- To view, visit http://gerrit.ovirt.org/36739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaeb92d69f2ba38746559df3e44f34a61fd880908 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
