Allon Mureinik has uploaded a new change for review. Change subject: core: ImagesHandler: Remove class qualifiers ......................................................................
core: ImagesHandler: Remove class qualifiers Removed redundant "ImagesHandler." qualifiers from calls to static methods in order to reduce code bloating and increase readability. Change-Id: Icfd78f564f04598b3aa55e77b806494fe3b2dced Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/36752/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java index bd284ed..783741a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java @@ -537,8 +537,7 @@ for (Disk disk : vm.getDiskMap().values()) { if (disk.getDiskStorageType() == DiskStorageType.IMAGE) { DiskImage diskImage = (DiskImage) disk; - diskImage.getSnapshots().addAll( - ImagesHandler.getAllImageSnapshots(diskImage.getImageId())); + diskImage.getSnapshots().addAll(getAllImageSnapshots(diskImage.getImageId())); } } } @@ -767,7 +766,7 @@ public static List<DiskImage> imagesSubtract(Iterable<DiskImage> images, Iterable<DiskImage> imagesToSubtract) { List<DiskImage> subtract = new ArrayList<>(); for (DiskImage image : images) { - if (ImagesHandler.getDiskImageById(image.getId(), imagesToSubtract) == null) { + if (getDiskImageById(image.getId(), imagesToSubtract) == null) { subtract.add(image); } } @@ -783,7 +782,7 @@ public static List<DiskImage> imagesIntersection(Iterable<DiskImage> images1, Iterable<DiskImage> images2) { List<DiskImage> intersection = new ArrayList<>(); for (DiskImage image : images1) { - if (ImagesHandler.getDiskImageById(image.getId(), images2) != null) { + if (getDiskImageById(image.getId(), images2) != null) { intersection.add(image); } } @@ -844,7 +843,7 @@ public static DiskImage createDiskImageWithExcessData(DiskImage diskImage, Guid sdId) { DiskImage dummy = DiskImage.copyOf(diskImage); dummy.setStorageIds(new ArrayList<Guid>(Collections.singletonList(sdId))); - dummy.getSnapshots().addAll(ImagesHandler.getAllImageSnapshots(dummy.getImageId())); + dummy.getSnapshots().addAll(getAllImageSnapshots(dummy.getImageId())); return dummy; } @@ -855,8 +854,8 @@ */ public static String getJsonDiskDescription(String diskAlias, String diskDescription) throws IOException { Map<String, Object> description = new HashMap<>(); - description.put(ImagesHandler.DISK_ALIAS, diskAlias); - description.put(ImagesHandler.DISK_DESCRIPTION, diskDescription != null ? diskDescription : ""); + description.put(DISK_ALIAS, diskAlias); + description.put(DISK_DESCRIPTION, diskDescription != null ? diskDescription : ""); return JsonHelper.mapToJson(description, false); } -- To view, visit http://gerrit.ovirt.org/36752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icfd78f564f04598b3aa55e77b806494fe3b2dced Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
