Arik Hadas has posted comments on this change. Change subject: core: fix broken functionality for cloning snapshot ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36678/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 638: } Line 639: Line 640: if (getParameters().getNewVmId() != null && Line 641: getVmStaticDao().get(getParameters().getNewVmId()) != null) { Line 642: return failCanDoAction(VdcBllMessages.VM_ID_EXISTS); can't we check getVmId() instead of introducing additional field in the parameters? Line 643: } Line 644: Line 645: return true; Line 646: } -- To view, visit http://gerrit.ovirt.org/36678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibff3323f31f1458e12d23c9e53a8ff20b97f4621 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
