Alon Bar-Lev has posted comments on this change. Change subject: core: Add local configuration helper ......................................................................
Patch Set 6: Hi, As for relocate the file - it is indeed needed. As for the upgrade - usually you don't need to touch configuration files upon upgrade, as the content there only overrides defaults. Because many programs needs to get the values, I am for using shell variant. It is the only format that is accessible for all. Any script can use (example): . /usr/share/ovirt-engine/bin/_defaults.vars . /etc/ovirt-enigne/config.vars And pass variables to whatever form it likes. This way all services and applications are synchronized using one simple method. As for dynamic/static processing, I would have separated the configuration that can be dynamically loaded into different file, and discuss that when we actually need this. I am not sure it is required, as for dynamic properties we always have the database. -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Anonymous Coward #1000055 Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
